Fix sunz normalization for viirs_compact #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDR data has sun_zenith_angle_correction_applied as default, viirs_compact does not! We now read data with the sunz_corrected modifier and satpy applyes the normalization. Note that reflective bands are read separately to avoid sunz_correction applied to the IR channels.
level1c4pps/viirs2pps_lib.py
Outdated
| scene[band].attrs['sun_zenith_angle_correction_applied'] = 'True' | ||
| if "sunz_corrected" not in scene['M05'].attrs['modifiers']: |
There was a problem hiding this comment.
Why checking just M05? Maybe more clear if you move this check to line 156 and do an assert there (if we do not trust satpy):
assert "sunz_corrected" in scene['M05'].attrs['modifiers']
Or I would recommend that you remove this check and add a new input parameter named sun_zenith_angle_correction_applied to this function so it looks something like this:
def set_header_and_band_attrs(scene, sun_zenith_angle_correction_applied, orbit_n=0):
if sun_zenith_angle_correction_applied:
scene[band].attrs['sun_zenith_angle_correction_applied'] = 'True'
Then you can probably remove the comments on line 117 and 118 as well. To me comments is an indication that the code can be written more clear than presently.
and e.g. one line 156 and 159 you can add the following line:
sun_zenith_angle_correction_applied = True
Pull Request Test Coverage Report for Build 13050156252Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDR data has sun_zenith_angle_correction_applied as default, viirs_compact does not! We now read data with the sunz_corrected modifier and satpy applyes the normalization. Note that reflective bands are
read separately to avoid sunz_correction applied to the IR channels.
pytest level1c4ppsflake8